New front struts-issue?
 

I replaced my front end, tie rods, wishbones, vc axel and springs & shocks.
I now have a clanking noise when breaking and when full lock.

This top mounts don't look right to me. Could this be my issue?

did you look at the spring seats ? the centre parts fail they become unbonded from the outside part its a common thing. a cheap but labour intensive fix though.

I replaced the whole assembly, see attached picture. Thanks

Looks about right, other than your dust cap is missing and the rubber fitting looks a bit distorted in those pictures but that may just be the lens on the camera.

Two thoughts. Did you torque everything up as per VIDA's directions upon refitting, and did you use Volvo original parts or some cheap aftermarket stuff. The later can be fine but the experience of members here is often that some of it really isn't. Especially top mounts and wishbones.

No offence intended but your picture to me shows what is known as a quick strut assembly. In my experience these are often extremely poor quality although they offer easier fitting. These are heavy cars and don’t wear cheap bits that well that often leads to these sort of issues as well as poor handling.

Have you checked the sway bar bushes? Also had a clunk, replaced shocks and top mounts, and it turned out to be the sway bar bushes.

You're better off buying a spring compressor and rebuilding onto the original struts unless they are completely shot! It's a pain but you can actually replace the bits that are shot, like the rubber bearing cup where the metal tube/bush becomes detached. i found Meyle or Febi to be fine substitutes for Volvo actual parts, in some cases the Meyle is the Volvo original..